Updated dot magic, with tests #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blink1073 How are you? I found some time to work on a couple of metakernel issues. I'm over my head on this one as I don't know github workflow syntax for how to install graphviz for the different OS test matrix entries. |
|
Hey @dsblank, I'm good, how are you? I'll push some changes :) |
|
I think it would make sense to skip the pydot tests if graphviz is not installed, to make it easier to run the tests in other environments/OSes. |
|
@blink1073 Good idea! I skipped the tests when not on linux. Thank you for your help, as always! |
|
Let me know when you're ready for a release |
|
All ready for release! Thank you! |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: