fix weight in interpolation #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunigami
commented
Nov 20, 2021
| @@ -220,7 +227,7 @@ def test_ints(self): | |||
| t = TDigest() | |||
| t.batch_update([1, 1, 2, 2, 3, 4, 4, 4, 5, 5]) | |||
| assert t.percentile(30) == 2 | |||
| assert t.percentile(40)*3 == 7 | |||
| assert t.percentile(40)*3 == 8 | |||
There was a problem hiding this comment.
eh, sorry I didn't realize I would have to update this test again >.<
| @@ -142,7 +142,6 @@ def test_negative_extreme_percentile_is_still_positive(self, empty_tdigest): | |||
| # Test https://github.com/CamDavidsonPilon/tdigest/issues/16 | |||
| t = TDigest() | |||
| t.batch_update([62.0, 202.0, 1415.0, 1433.0]) | |||
| print(t.percentile(26)) | |||
|
Cool! Thanks @kunigami! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially: #52 with extra simplifications.
Intuitively if
pis close tot(the mid point of the previous cluster), the weight forc_i.meanshould be higher. Whereas right nowz1 = p - tis smaller the closerpis tot.Note that when we do this change, the
p == t + kis handled too:Also noting that
k = z1 + z2:I added a test case to show case this:
it currently returns
132.0forp=40.