-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature](bangc-ops):add new op masked_col2im_forward #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defei-coder
force-pushed
the
masked_conv2d
branch
2 times, most recently
from
May 8, 2023 07:14
ecb659f
to
576112c
Compare
PetrelYy
reviewed
May 8, 2023
docs/bangc-docs/design_docs/masked_col2im_forward/masked_col2im_forward.md
Outdated
Show resolved
Hide resolved
PetrelYy
reviewed
May 8, 2023
bangc-ops/test/mlu_op_gtest/pb_gtest/src/zoo/masked_col2im_forward/masked_col2im_forward.h
Outdated
Show resolved
Hide resolved
PetrelYy
reviewed
May 8, 2023
bangc-ops/kernels/masked_col2im_forward/masked_col2im_forward_union1.mlu
Show resolved
Hide resolved
PetrelYy
reviewed
May 8, 2023
PetrelYy
reviewed
May 8, 2023
defei-coder
force-pushed
the
masked_conv2d
branch
4 times, most recently
from
May 9, 2023 02:58
44f20f9
to
6ca03e8
Compare
AquamarineSu
reviewed
May 9, 2023
AquamarineSu
approved these changes
May 9, 2023
DanieeelLiu
approved these changes
May 18, 2023
PetrelYy
approved these changes
May 23, 2023
PetrelYy
approved these changes
May 23, 2023
PetrelYy
approved these changes
May 23, 2023
defei-coder
force-pushed
the
masked_conv2d
branch
2 times, most recently
from
May 23, 2023 09:33
2e45e7c
to
02134e9
Compare
duzekunKTH
reviewed
May 24, 2023
duzekunKTH
reviewed
May 24, 2023
bangc-ops/kernels/masked_col2im_forward/masked_col2im_forward_union1.mlu
Show resolved
Hide resolved
defei-coder
force-pushed
the
masked_conv2d
branch
from
May 24, 2023 06:48
02134e9
to
94137cc
Compare
defei-coder
force-pushed
the
masked_conv2d
branch
from
May 29, 2023 02:44
94137cc
to
314e884
Compare
duzekunKTH
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot.
1. Motivation
Add new op masked_col2im_forward
2. Modification
Modify files
Add new files
3. Test Report
If you want to know how to do operator testing, you can see GTest-User-Guide-zh.
3.1 Modification Details
3.1.1 Accuracy Acceptance Standard
For static threshold standard details, see: MLU-OPS Accuracy Acceptance Standard.
3.1.2 Operator Scheme checklist
MLU590
3.1.3 New Feature Test
If you have checked the following items, please tick the relevant box.
3.1.4 Parameter Check
When a new operator is submitted, the test points are given and the test results are stated.
3.2 Accuracy Test
For the cases used in the New Feature Test section, the features and the number of cases are recorded here. When multiple operations are tested, multiple tables are needed to include details of these operations.
Operation:
--thread=NUM
3.3 Performance Test
See MLU-OPS Performance Acceptance Standard for details.
Platform:MLU370
Platform:MLU590
3.4 Summary Analysis
Please give a brief overview here, if you want to note and summarize the content.