Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature](bangc-ops): box_iou_rotated support nan and inf. #701

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

DanieeelLiu
Copy link
Collaborator

@DanieeelLiu DanieeelLiu commented Jun 1, 2023

Thanks for your contribution and we appreciate it a lot.

1. Motivation

Box_iou_rotated support nan/inf.

2. Modification

Please briefly describe what modification is made in this pull request, and indicate where to make the modification.

3. Test Report

If you want to know how to do operator testing, you can see GTest-User-Guide-zh.

3.1 Modification Details

3.2 Accuracy Test

Platform:MLU370 & MLU590

cases status
nan/inf PASSED 80 test cases from 1 test suite ran.
release_test PASSED 28 test cases from 1 test suite ran.
release_temp PASSED 21 test cases from 1 test suite ran.

3.3 Performance Test

See MLU-OPS Performance Acceptance Standard for details.

Platform:MLU370

Mlu_hardware_time(us) Mlu_hardware_time_baseline(us) time_improve_percent Data_type Shape params
107 106.33 -0.63% FP32 {'input_dim': [[32, 5], [32, 5]]}, {'output_dim': [[32]]} {'mode': 1, 'aligned': True}
299 298 -0.34% FP32 {'input_dim': [[640, 5], [640, 5]]} {'output_dim': [[640]]} {'mode': 1, 'aligned': True}
4146.24 4145.01 -0.03% FP32 {'input_dim': [[2400, 5], [2400, 5]]} {'output_dim': [[2400]]} {'mode': 1, 'aligned': True}
17907.01 17903 -0.02% FP32 {'input_dim': [[18430, 5], [18430, 5]]} {'output_dim': [[18430]]} {'mode': 1, 'aligned': True}
20784 20778.83 -0.02% FP32 {'input_dim': [[38000, 5], [38000, 5]]} {'output_dim': [[38000]]} {'mode': 1, 'aligned': True}
218 217 -0.46% FP32 {'input_dim': [[160, 5], [160, 5]]} {'output_dim': [[160]]} {'mode': 1, 'aligned': True}
142.13 142 -0.09% FP32 {'input_dim': [[260, 5], [260, 5]]} {'output_dim': [[260]]} {'mode': 1, 'aligned': True}
250 249 -0.40% FP32 {'input_dim': [[570, 5], [570, 5]]} {'output_dim': [[570]]} {'mode': 1, 'aligned': True}
347 346 -0.29% FP32 {'input_dim': [[2048, 5], [2048, 5]]} {'output_dim': [[2048]]} {'mode': 1, 'aligned': True}
2278.03 2045.490062 -0.10% FP32 {'input_dim': [[18432, 5], [18432, 5]]} {'output_dim': [[18432]]} {'mode': 1, 'aligned': True}
2047.449933 2199.03 -3.59% FP32 {'input_dim': [[250, 5], [5, 5]]} {'output_dim': [[250, 5]]} {'mode': 1, 'aligned': false}

Platform:MLU590

Mlu_hardware_time(us) Mlu_hardware_time_baseline(us) time_improve_percent Data_type Shape params
88.83 89.12 0.33% FP32 {'input_dim': [[32, 5], [32, 5]]}, {'output_dim': [[32]]} {'mode': 1, 'aligned': True}
244.01 245 0.40% FP32 {'input_dim': [[640, 5], [640, 5]]} {'output_dim': [[640]]} {'mode': 1, 'aligned': True}
1155 1155.18 0.02% FP32 {'input_dim': [[2400, 5], [2400, 5]]} {'output_dim': [[2400]]} {'mode': 1, 'aligned': True}
23706.01 23705.99 0% FP32 {'input_dim': [[18430, 5], [18430, 5]]} {'output_dim': [[18430]]} {'mode': 1, 'aligned': True}
13031.18 13031.03 0% FP32 {'input_dim': [[38000, 5], [38000, 5]]} {'output_dim': [[38000]]} {'mode': 1, 'aligned': True}
177.02 178 0.55% FP32 {'input_dim': [[160, 5], [160, 5]]} {'output_dim': [[160]]} {'mode': 1, 'aligned': True}
116 117 0.85% FP32 {'input_dim': [[260, 5], [260, 5]]} {'output_dim': [[260]]} {'mode': 1, 'aligned': True}
204.04 205 0.47% FP32 {'input_dim': [[570, 5], [570, 5]]} {'output_dim': [[570]]} {'mode': 1, 'aligned': True}
189 190 0.53% FP32 {'input_dim': [[2048, 5], [2048, 5]]} {'output_dim': [[2048]]} {'mode': 1, 'aligned': True}
642.03 643.1 0.17% FP32 {'input_dim': [[18432, 5], [18432, 5]]} {'output_dim': [[18432]]} {'mode': 1, 'aligned': True}
2066 2092.87 4.49% FP32 {'input_dim': [[250, 5], [5, 5]]} {'output_dim': [[250, 5]]} {'mode': 1, 'aligned': false}

3.4 Summary Analysis

Please give a brief overview here, if you want to note and summarize the content.

@DanieeelLiu DanieeelLiu changed the title [WIP][Feature](bangc-ops): box_iou_rotated support nan and inf. [Feature](bangc-ops): box_iou_rotated support nan and inf. Jun 1, 2023
@duzekunKTH duzekunKTH added this to the v0.8.0 milestone Jun 2, 2023
@duzekunKTH duzekunKTH merged commit 7a4fb5f into Cambricon:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants