Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature](bangc-ops): add transform binary oprator. #839

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Conversation

TingyuZhangSie
Copy link
Collaborator

No description provided.

@TingyuZhangSie TingyuZhangSie force-pushed the transform_op branch 2 times, most recently from da68319 to beea2a9 Compare September 19, 2023 09:58
@PetrelYy PetrelYy added the BANGC label Sep 20, 2023
@PetrelYy PetrelYy added this to the v0.9.0 milestone Sep 20, 2023
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Show resolved Hide resolved
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Show resolved Hide resolved
docs/bangc-docs/user_guide/9_operators/index.rst Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/mlu_op.h Outdated Show resolved Hide resolved
bangc-ops/kernels/transform/transform.cpp Outdated Show resolved Hide resolved
@TingyuZhangSie TingyuZhangSie force-pushed the transform_op branch 4 times, most recently from 4d4a7fd to fe68e6c Compare October 12, 2023 02:47
@TingyuZhangSie TingyuZhangSie force-pushed the transform_op branch 3 times, most recently from c20c550 to 0b52f52 Compare October 12, 2023 03:04
@TingyuZhangSie
Copy link
Collaborator Author

TingyuZhangSie commented Oct 16, 2023

1. Motivation

将transform算子以二进制形式合入mluops

2. Modification

增加算子transform

3. Test Report

If you want to know how to do operator testing, you can see GTest-User-Guide-zh.

3.1 Modification Details

3.1.1 Accuracy Acceptance Standard

For static threshold standard details, see: MLU-OPS Accuracy Acceptance Standard.

  • static threshold
    • diff3
      • mlu diff3 == 0
      • mlu diff3_1 == 0
      • mlu diff3_2 == 0

3.1.2 Operator Scheme checklist

  • Supported hardware
    • MLU370
    • MLU590
  • Job types
    • BLOCK
    • UNION1
    • UNION2
    • UNION4
    • The operator will dynamically select the most suitable task type, for example, UNION8

3.2 Accuracy Test

3.2.1 Accuracy Test

If you have checked the following items, please tick the relevant box.

  • Data type test (e.g. float32/int8)
  • Multi-dimensional tensor test
  • Layout test
  • Different size/integer remainder end segment/alignment misalignment test
  • Zero dimensional tensor test/zero element test
  • stability test
  • Multiple platform test
  • Gen_case module test, see: Gencase-User-Guide-zh
  • Nan/INF tests
  • Bug fix tests
  • For memory leak check details, see: GTest-User-Guide-zh
  • For code coverage check details, see: GTest-User-Guide-zh
  • For I/O calculation efficiency check details, see: MLU-OPS-Performance-Acceptance-Standard

3.2.2 Parameter Check

Test Point-1: When a new operator is submitted, the test points are given and the test results are stated. Acceptance Standard: Normal error.

Please fill your test results(Error Message) in here, ...

Test Point-2: Whether illegal parameters are passed. Acceptance Standard: Normal error.

Test results...

3.3 Performance Test

See MLU-OPS Performance Acceptance Standard for details.

Platform:MLU370

[----------] Global test environment tear-down
[ SUMMARY  ] Total 1 cases of 1 op(s).
ALL PASSED.
[==========] 1 test case from 1 test suite ran. (2989 ms total)
[  PASSED  ] 1 test case.

Platform:MLU590

[----------] Global test environment tear-down
[ SUMMARY  ] Total 1 cases of 1 op(s).
ALL PASSED.
[==========] 1 test case from 1 test suite ran. (449 ms total)
[  PASSED  ] 1 test case.

3.4 Summary Analysis

Please give a brief overview here, if you want to note and summarize the content.

@PetrelYy PetrelYy merged commit 4d2653e into master Oct 16, 2023
1 check passed
@PetrelYy PetrelYy deleted the transform_op branch October 16, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants