-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heading filter breaks substrate mapping #142
Comments
I confirmed I can export sonar mosaics with heading filter applied [no shadow removal]: Click to see log
|
I receive the same error when trying to export sonar mosaic with shadow removal: Click to see error
Click to see log
|
Moved the sonar log filtering before the depth and shadow workflows 4757ab2. Sonar mosaic was able to export: Click to see log
|
Set shadows to be removed and predict substrate, but received an error: Click to see error
Click to see log
This is a different error. The same error was reported by another individual on a different recording. |
If the heading filter is turned off, a substrate map is exported: Click to see log
Notably, when adding the heading filter workflow, the smooth trackline workflow was also updated (e7fc3be) to run from a new function. However, that function isn't called in main_mapSubstrate.py and is still hardcoded: PINGMapper/pingmapper/main_mapSubstrate.py Lines 236 to 354 in 4757ab2
|
Made substrate mapping workflow smooth trackline using |
106b194 did not fix the issue (substrate mapping with heading filter applied). Click to see error
Click to see log
|
Able to export substrate after 5bb0c4f. Testing on user's large dataset. |
I had an error similar to the first error:
|
Describe the bug
The new heading filter workflow results in an error during the substrate prediction workflow. There is a mismatch between the size of the the shadow mask and the sonar chunk that is being predicted upon.
Click to see error
To Reproduce
Steps to reproduce the behavior:
Click to see log
Expected behavior
Substrate maps should be exported with the heading filter applied.
Screenshots
NA
Desktop (please complete the following information):
Additional context
Resulted from #126
First reported by a user
The text was updated successfully, but these errors were encountered: