Skip to content

Commit

Permalink
add to changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
ghiculescu committed Aug 25, 2019
1 parent 1997832 commit a9642b2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
## 3.0.2

* [#590](https://github.com/CanCanCommunity/cancancan/pull/590): Fix Rule#inspect when rule is created through a SQL array. ([@frostblooded][])
* [#592](https://github.com/CanCanCommunity/cancancan/pull/592): Prevent normalization of through polymorphic associations.([@eloyesp][])
* [#592](https://github.com/CanCanCommunity/cancancan/pull/592): Prevent normalization of through polymorphic associations. ([@eloyesp][])
* [#600](https://github.com/CanCanCommunity/cancancan/pull/600): Switch back to eagerly loading associations for ActiveRecord 5.0.x and 5.1.x. 5.2+ will still not automatically eager load. ([@ghiculescu][])
* [#600](https://github.com/CanCanCommunity/cancancan/pull/600): Fix regression when using accessibl_by with default_scopes that set an order. ([@ghiculescu][])

## 3.0.1

Expand Down Expand Up @@ -650,3 +652,4 @@ Please read the [guide on migrating from CanCanCan 2.x to 3.0](https://github.co
[@kaspernj]: https://github.com/kaspernj
[@frostblooded]: https://github.com/frostblooded
[@eloyesp]: https://github.com/eloyesp
[@ghiculescu]: https://github.com/ghiculescu
2 changes: 2 additions & 0 deletions spec/changelog_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
expect(changelog.end_with?("\n")).to be true
end

# if this test fails it means you probably haven't added a link
# for your GH username at the bottom of the CHANGELOG
it 'has link definitions for all implicit links' do
implicit_link_names = changelog.scan(/\[([^\]]+)\]\[\]/).flatten.uniq
implicit_link_names.each do |name|
Expand Down

0 comments on commit a9642b2

Please sign in to comment.