Merge alias actions when merging abilities #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #468 Closes #280 This changes the behaviour of `Ability#merge` to also include defined `alias_actions`. If a collision between the defined aliases occurs the actions on +self+ will be overwritten with those on the passed object. The inline documentation has been updated in order to reflect those changes.
coorasse
approved these changes
Oct 23, 2018
| # | ||
| # read_ability = ReadAbility.new | ||
| # read_ability.merge(ShowAbility) | ||
| # read_ability.aliased_actions #=> [:see => [:show]] |
There was a problem hiding this comment.
Honestly, I'd have expected them to be see: [:show, :index] since they are merged.
There was a problem hiding this comment.
@coorasse You're right merge would kinda indicate that, but would that make sense?
If we merge two abilities we expect to gain the rules from the ability which was passed. But it wouldn't really make sense to combine the actions defined for an alias since it could change the "meaning" of that alias.
Even tho it seems like the more intuitive approach, I think it would lead to some surprises. I choose this approach because it's "safer" and doesn't change the rules defined for an alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #468
Closes #280
This changes the behaviour of
Ability#mergeto also include definedalias_actions.If a collision between the defined aliases occurs the actions on
selfwill be overwritten with those on the passed object. For an example see this added spec.
The inline documentation has been updated in order to reflect those
changes.