Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve usage of the rules compressor #575

Merged
merged 2 commits into from
Mar 16, 2019
Merged

Improve usage of the rules compressor #575

merged 2 commits into from
Mar 16, 2019

Conversation

coorasse
Copy link
Member

@coorasse coorasse commented Mar 16, 2019 •
edited
Loading

Different improvements:

  • The RulesCompressor introduced in the previous versions can be used to reduce also the number of joins executed. This PR uses compressed rules also when generating the joins, reducing the complexity of the generated queries for accessible_by.
  • A piece of code wrote for MetaWhere, now not supported anymore, has been removed.
  • When printing a rule, the scopes are not executed
  • Scopes can be compressed as well by the rules compressor
  • Switch tests to Rails 6 beta3

@coorasse coorasse changed the base branch from develop to feature/3.0.0 March 16, 2019 09:29
@coorasse coorasse merged commit e7ce7f8 into feature/3.0.0 Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coorasse