Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix method reference block regression #583

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Fix method reference block regression #583

merged 1 commit into from
Apr 15, 2019

Conversation

coorasse
Copy link
Member

@coorasse coorasse commented Apr 13, 2019 •
edited
Loading

Fixes #582

@coorasse coorasse self-assigned this Apr 13, 2019
@coorasse coorasse force-pushed the feature/use_reference_block branch from b68a313 to 7f348ff Compare April 13, 2019 09:18
@coorasse coorasse mentioned this pull request Apr 15, 2019
Closed
@coorasse coorasse merged commit f9372fc into develop Apr 15, 2019
@coorasse coorasse deleted the feature/use_reference_block branch April 15, 2019 20:19
@sudoremo
Copy link
Contributor

sudoremo commented Feb 9, 2021 •
edited
Loading

May I ask why the compact is necessary for this to work? I have a case where I'm deliberately passing nil to an extra argument and it gets stripped, which I find to be rather an odd behavior and don't see a workaround.

Do you agree and may there be an option to fix this regression without using compact / stripping nil values? Many thanks for your time.

P.S.: Wünsche en schöne Tag in Züri ;)

@sudoremo sudoremo mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@coorasse coorasse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method reference error
2 participants
@coorasse @sudoremo