Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.accessible_by_strategy only impacts the AR adapter #674

Merged
merged 2 commits into from
Dec 14, 2020
Merged

config.accessible_by_strategy only impacts the AR adapter #674

merged 2 commits into from
Dec 14, 2020

Conversation

ghiculescu
Copy link
Contributor

Fixes #671

@ghiculescu ghiculescu mentioned this pull request Dec 14, 2020
Closed
@ghiculescu ghiculescu changed the title config.accessible_by_strategy only impacts the AR adapter config.accessible_by_strategy only impacts the AR adapter Dec 14, 2020
coorasse
coorasse approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!!

@ghiculescu
Copy link
Contributor Author

@coorasse fixed the build. not sure why it only started failing here :/

@coorasse coorasse merged commit 662b6c1 into CanCanCommunity:develop Dec 14, 2020
@ghiculescu ghiculescu deleted the dont-rely-on-ar branch December 14, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coorasse coorasse coorasse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CanCanCan 3.2 requires ActiveRecord adapter
2 participants
@ghiculescu @coorasse