Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bundler-cache: true to automatically cache installed gems #682

Merged
merged 4 commits into from
Mar 14, 2021

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Dec 30, 2020

No description provided.

@eregon eregon mentioned this pull request Dec 30, 2020
@eregon
Copy link
Contributor Author

eregon commented Dec 30, 2020

Run bundle exec rubocop
Error: Unsupported Ruby version 2.1 found in `TargetRubyVersion` parameter (in vendor/bundle/ruby/2.4.0/gems/rainbow-3.0.0/.rubocop.yml). 2.1-compatible analysis was dropped after version 0.58.
Supported versions: 2.2, 2.3, 2.4, 2.5, 2.6
Error: Process completed with exit code 2.

That's RuboCop looking at files it should not, will try to tell it not to do that.

@eregon
Copy link
Contributor Author

eregon commented Dec 30, 2020

@coorasse Passing now :)

I guess TravisCI could be removed since GHA works fine?

@artplan1
Copy link

hi @eregon, I just checked issue with exclude (disscused in ruby/setup-ruby#131) and it seems it works correctly by default.

But quotes in gemfiles should be fixed (or cop should be disabled for gemfiles) :)

failed build because of quotes: https://github.com/artplan1/cancancan/runs/1626274482?check_suite_focus=true#step:6:13
green build with fixes: https://github.com/artplan1/cancancan/runs/1626294534?check_suite_focus=true#step:6:13
changes: https://github.com/artplan1/cancancan/pull/1/files

@eregon
Copy link
Contributor Author

eregon commented Dec 30, 2020

But quotes in gemfiles should be fixed (or cop should be disabled for gemfiles) :)

I assume that's not an option, because these gemfiles are generated by Appraisal.
Although, there might be a newer version of Appraisal or some way to configure it to use single quotes.
Still, I'd like to keep it simple in this PR :)

@eregon
Copy link
Contributor Author

eregon commented Feb 17, 2021

@coorasse Could you merge this?
It also excludes a failing combination of TruffleRuby + Rails 4 (cannot work, TruffleRuby now targets Ruby 2.7 which doesn't work on Rails 4).

Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coorasse coorasse merged commit 81869f9 into CanCanCommunity:develop Mar 14, 2021
@eregon eregon deleted the bundler-cache branch March 14, 2021 15:04
@eregon eregon mentioned this pull request Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants