Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change add_rule raise error to nil when subject nil #684

Conversation

ayumu838
Copy link
Contributor

@ayumu838 ayumu838 commented Jan 5, 2021

This PR change raise error to nil when subject is nil

Because my development service down when not exist subject active model.
I expect to nothing happen in this case.


now

action subject active model result
manage Foo None raise error

expected

action subject active model result
manage Foo None nothing

@coorasse
Copy link
Member

coorasse commented Jul 6, 2022

We don't support defining abilities without a subject anymore. See #489

@coorasse coorasse closed this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants