New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] - Gradle cleanup #265

Closed

Alireza-Farahani opened this issue Nov 14, 2021 · 1 comment · Fixed by #266

Contributor

Alireza-Farahani commented Nov 14, 2021

There are some small unnecessary or deprecated thing in project's gradle files like:

Since Kotlin 1.4.0, there's no need to add standard library as a dependency
Since AGP 4.1 compileSdkVersion, targetSdkVersion and minSdkVersion are deprecated in favor of shorter properties of compileSdk, targetSdk and minSdk
Since AGP 4.2 java 1.8 support is enabled by default. We could mention this in ReadMe.

See original article for more info. I have these changes ready in my fork and could create a pull request if you are OK with it.

The text was updated successfully, but these errors were encountered:

Member

Canato commented Nov 15, 2021

Hey @Alireza-Farahani thanks for raising this, please be free to create a PR so we can improve this ^^

We just need to be sure we keep backward compatibility.

Alireza-Farahani mentioned this issue

Enh/gradle cleaning #266

Merged

4 tasks

Canato closed this as completed in #266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment