Enh/gradle cleaning #266
Merged
Enh/gradle cleaning #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canato
requested changes
Nov 15, 2021
Comment on lines
-24
to
-48
| # Enable Kapt Incremental annotation processing requeste | ||
| kapt.incremental.apt=true | ||
|
|
||
| # Decrease gradle builds time | ||
| kapt.use.worker.api=true | ||
|
|
||
| # turn off AP discovery in compile path, and therefore turn on Compile Avoidance | ||
| kapt.include.compile.classpath=false | ||
|
|
||
| # AndroidX package structure to make it clearer which packages are bundled with the | ||
| # Android operating system, and which are packaged with your app's APK | ||
| # https://developer.android.com/topic/libraries/support-library/androidx-rn | ||
| # Android plugin uses the appropriate AndroidX library instead of a Support Library. | ||
| android.useAndroidX=true | ||
|
|
||
| # Automatically convert third-party libraries to use AndroidX | ||
| android.enableJetifier=true | ||
|
|
||
| # Once you have globally enabled the Daemon in this way, all your builds will take advantage of the | ||
| # speed boost, regardless of the version of Gradle a particular build uses. | ||
| org.gradle.daemon=true | ||
|
|
||
| # Run with file system watching enabled | ||
| # https://docs.gradle.org/current/userguide/gradle_daemon.html#sec:daemon_watch_fs | ||
| org.gradle.vfs.watch=true |
There was a problem hiding this comment.
Could you explain why we don't need this anymore or why was not been used? Thanks!
There was a problem hiding this comment.
For "file system watching" we don't need it because it's enabled by default from Gradle 7.0 and later and we are using Gradle 7.0.2.
For Gradle daemon it's too is enabled by default.
For Jetifire, we don't need it anymore, because there's no old support library dependency in project classpath (either from explicit dependencies or transitive dependencies). So there's nothing for Jetifier to do. (In fact next Android Studio warns about using Jetifire)
Canato
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #265
Template 1 [New Feature]
Description:
I have an obsession for cleanup and I noticed there are some things in Gradle related files which can be removed or changed from deprecated ones to newer ones. Source for first three bullet here.
compileSdkVersion,targetSdkVersionandminSdkVersionare deprecated in favor of shorter properties ofcompileSdk,targetSdkandminSdklifeCycle,fragment-testingandrobolectricare unused and could be removed.Check list for the Code Reviewer: