Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #99
fix #83
fix #84
Description:
Most of the usage of this library expect the
URI
to be a file path, what is not it main propose.Based on this was decided to split into two methods and remove the old method.
This will break the contract, making us release a new major version (
3.0.0
)Should be a small a specific change so we will avoid to deprecate.
Open for suggestions in how to do and naming. Please open a discussion for it.
For now, the possible names:
getUriFilePath
getUriContent
keeping the
uri
term in both names is done on propose so the users can easily find.Check list for the Code Reviewer: