Add java sample and fix bug calling lib from java

[junaediwidjojo]

sample for #113

Bug

Cause:

CropImage.getActivityResult not working in java Code

I add some sample java code to help you solve this issue.
Let me know what you need more to fix this bug.

[Canato]

This is some great work! thanks

We are closer to have it fully working on java =D

Besides the comments that I put, please feel free to already fix the bugs you find when you try to use the methods in java =)

[junaediwidjojo]

@Canato
I hope I already made all you requested in previous comments
Please let me know is something missing

[Canato]

Nice! improving, but still need some work on it.

[junaediwidjojo]

Hello @Canato

Please check my latest commit for the revisions.

Thank you

[Canato]

Solid effort 👏

We are almost done! just need to bring the final implementations (I comment on it, so I won't forget) !

Thanks for the hard work, sorry to take longer to review, I'm switching off now, back tomorrow!

[junaediwidjojo]

I already open the remark that you need.
Actually that's the bug in java when CropImage.getActivityResult(data) is marked as error in Java

[Canato]

I add some changes need to make this piece work!

We are close to have it running so we can release =)

Please don't forget to:

• Update the Changelog
• Format your code

To format you code select all the code cmd+a and click control+option+i and control+option+L this will fix the spacing and index based on the project codestyle.
If you don't use mac need to find this commands online, sorry I only know using mac

[Canato]

Hey @junaediwidjojo this working is going amazing

I already open the remark that you need.

sorry, what you mean by "remark"?

Actually that's the bug in java when CropImage.getActivityResult(data) is marked as error in Java

indeed! I add a review showing how to solve this so we can release soon

[junaediwidjojo]

Thanks for the great feedback!
I already revised it, just let me know if something bothering you again.

I mean remark is comment, just forget about my misconcept

[Canato]

All good! I'm happy to merge as soon you update the changelog!
We will release this today 🎉

[Canato]

BTW, the CI is complaning:
SMainActivity.kt Unused import

Don't forget to run the Codestyle, how to do this

[junaediwidjojo]

Trying to fulfill your request.
Hope that satisfy you well.

Let me know if something need to be configured again.

[Canato]

Trying to fulfill your request.
Hope that satisfy you well.

Let me know if something need to be configured again.

All looking good, we just need the CHANGELOG update =D
Updating the CHANGELOG

Solid work @junaediwidjojo

[junaediwidjojo]

Hello @Canato
sorry for late reply

Is this still necessary to update the change log? I see you already merge the branch.

Anyway, to use the fixed version, I need to load version 3.1.0, is that correct?

[Canato]

Hello @Canato
sorry for late reply

Is this still necessary to update the change log? I see you already merge the branch.

Anyway, to use the fixed version, I need to load version 3.1.0, is that correct?

Not necessary anymore, I wanted to release so I did my self. Thanks for the amazing work.

Indeed, version 3.1 should work