Sample/extend activity #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@loukwn I believe this change is what was need to change muzmatch into this library. Was not working before, but now with the method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #34
close #46
New Feature - 46
Description:
Create a new sample app that extend the Crop Activity, this help us for testing and keep the code quality on changes.
Bug
Cause:
After changing the code from java to Kotlin we moved the view reference to viewBinding, because of this we lost the ID reference.
Reproduce
GIVEN: Extend
CropImageActivityWHEN: call
cropImage()THEN:
result.uriwill benullHow the bug was solved:
So we need to create a function
setCropImageView()that should be called when extending the activity to setupCropImageViewnot perfect, because the dev can forget to setup, but is a beginCheck list for the Code Reviewer: