Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BitmapUtils to Kotlin #98

Merged
merged 9 commits into from
Mar 27, 2021
Merged

Refactor BitmapUtils to Kotlin #98

merged 9 commits into from
Mar 27, 2021

Conversation

SanjayDevTech
Copy link
Contributor

close #35

Description:

Migrated BitmapUtils to Kotlin

@SanjayDevTech
Rename .java to .kt
c805c8d
@SanjayDevTech
Refactor BitmapUtils to Kotlin Lang
e8c2c16 
* Rename BitmapUtils.java to BitmapUtils.kt
* Convert BitmapUtils to Kotlin
* Update CHANGELOG.md
@SanjayDevTech SanjayDevTech requested a review from a team as a code owner March 23, 2021 20:52
@Canato Canato self-requested a review March 23, 2021 23:32
@Canato Canato self-assigned this Mar 23, 2021
Canato
Canato requested changes Mar 23, 2021
View reviewed changes
Copy link
Member

@Canato Canato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work so far! some points for improvement =D.

Please make the CI pass, so I can jump in and put the last bits in place ;)

Thanks ^^

.idea/codeStyles/Project.xml Outdated Show resolved Hide resolved
cropper/src/main/java/com/canhub/cropper/BitmapCroppingWorkerJob.kt Outdated Show resolved Hide resolved
cropper/src/main/java/com/canhub/cropper/CropImageView.kt Outdated Show resolved Hide resolved
cropper/src/main/java/com/canhub/cropper/BitmapUtils.kt Outdated Show resolved Hide resolved
cropper/src/main/java/com/canhub/cropper/BitmapUtils.kt Outdated Show resolved Hide resolved
cropper/src/main/java/com/canhub/cropper/BitmapUtils.kt Outdated Show resolved Hide resolved
cropper/src/main/java/com/canhub/cropper/BitmapUtils.kt Outdated Show resolved Hide resolved
cropper/src/main/java/com/canhub/cropper/BitmapUtils.kt Outdated Show resolved Hide resolved
cropper/src/main/java/com/canhub/cropper/BitmapUtils.kt Outdated Show resolved Hide resolved
@SanjayDevTech
Copy link
Contributor Author

@Canato Fixed lint checks

@SanjayDevTech
Copy link
Contributor Author

@Canato I think I resolved all issues... 😀

@SanjayDevTech
Copy link
Contributor Author

🙂 @Canato Updated

Canato
Canato approved these changes Mar 27, 2021
View reviewed changes
Copy link
Member

@Canato Canato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks man!!!

@Canato Canato merged commit 5218fc9 into CanHub:main Mar 27, 2021
@SanjayDevTech
Copy link
Contributor Author

😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Canato Canato Canato approved these changes

Assignees

@Canato Canato

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor BitmapUtils to kotlin
2 participants
@SanjayDevTech @Canato