Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wren-ui): Separate view step sql & view full sql condition #904

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

andreashimin
Copy link
Contributor

Description

In PR #899, adding isViewSQL caused confusion within the CollapseContent template condition. This fix introduces isViewStepSQL to more clearly separate the conditions.

@andreashimin andreashimin added the module/ui UI related label Nov 13, 2024
Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreashimin andreashimin merged commit 0774299 into main Nov 15, 2024
7 checks passed
@andreashimin andreashimin deleted the fix/ui branch November 15, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/ui UI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants