Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wren-ui/e2e): Added E2E tests for Snowflake Data Source #927

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

ongdisheng
Copy link
Contributor

Description

This PR adds E2E tests for the Snowflake data source implemented in #911 and has been verified locally with the results as shown below. Your review would be greatly appreciated—thank you in advance @fredalai 😊.

Screenshots

Screenshot 2024-11-19 at 8 51 56 PM

@ongdisheng ongdisheng marked this pull request as ready for review November 19, 2024 13:14
Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredalai fredalai merged commit 311212b into Canner:main Nov 20, 2024
@ongdisheng ongdisheng deleted the e2e-snowflake branch November 23, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants