feat(function-list): search file by data source name #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
reviewed
Oct 29, 2024
ibis-server/app/config.py
Outdated
| @@ -58,6 +58,13 @@ def update(self, diagnose: bool): | |||
| else: | |||
| self.init_logger() | |||
|
|
|||
| def get_remote_function_list_path(self, data_source: str) -> str: | |||
| return ( | |||
| f"{self.remote_function_list_path}/{data_source}/functions.csv" | |||
There was a problem hiding this comment.
maybe change to this pattern? We don't need another folder, I guess.
Suggested change
| f"{self.remote_function_list_path}/{data_source}/functions.csv" | |
| f"{self.remote_function_list_path}/{data_source}.csv" |
grieve54706
changed the title
goldmedal
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #858
Change the function file path to a folder path and search the file by data source name.
The system will find the CSV file by the data source name in the path from the env var
Before
Env var
Actual path
API
After
Env var
Actual path by data source
API