don't kill jobs on every change #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the job running strategy. Previously, the current running job was killed as soon as there was a change, to allow a faster execution of the new job. This had the downside of never allowing any job to complete if you were always changing files and the job were just a little too long to finish between changes. With the new strategy, bacon lets the job finish (unless you ask for a refresh or change the mission), display the result, and if some changes occured after the last job start, then start a new job. Also, the number of changes since the last job *start* is displayed (this display should become opt-in before merging into main) (note: it's the number of events, not of modified files) Fix #206
|
released in 2.21.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings 2 settings:
With
show_changes_count = true, you can see the number of file changes that occurred since last job start.The
on_change_strategysetting lets you define how bacon reacts to a change, with two possible values:With
on_change_strategy = "kill_then_restart", the current job is immediately killed and a new job restarted. This is the behavior that bacon had before this PR. It has the downside of never allowing any job to complete if you're always changing files and the job is just a little too long to finish between changes.With
on_change_strategy = "wait_then_restart"(which is the new default, so you can omit it), bacon waits for the job to finish before restarting it. This is probably much better when the jobs aren't instant and you want to continue changing files while it's computing.The
on_change_strategycan be defined in the global prefs, in the project settings, and even for a specific job.Fix #206