-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically push copies of Cantera examples to dedicated repository #1177
Conversation
So is the idea that the I guess what I'd like to understand is how you see this repository being used. For accessing individual examples, I think the index at https://cantera.org/examples is always going to offer us the most flexibility in terms of presenting the examples to users, and we already have a number of partially-executed or at least planned enhancements to that interface. The other scenario I can imagine is wanting to quickly download all of the examples, which was why I suggested packaging a This interface provides that in a roundabout way, since Git does offer that as an option under the "Code" button. But I am a little concerned that this will encourage users to clone this repo and make changes in it, which isn't really ideal since it would be difficult to bring any such changes back in to the original repos. |
@speth I can see the logic in that, if I wanted to actually run an example locally, there are two inconveniences:
Can you say more, here? Do you mean packaging a zip file that could be downloaded from the website? If so, i agree that this might be a better solution, in that for case 1 above, having to get up to speed on git might already be too large a barrier, and also to avoid your concern, about people committing changes to a repo that isn't passed back to the source code. That said, I suppose that the two approaches are not mutually exclusive. |
Ah, just found the discussion on Cantera/enhancements#129 Catching up... |
@speth One possible use would be to build the website. It would be easier to clone a sample-specific repo and pull examples from there rather than the (much larger) Cantera/cantera repo.
I think we can add a README that says in big bold letters DO NOT CLONE THIS SUBMIT CHANGES OVER HERE, an issue template that says the same thing, and close any PRs that are opened, either automatically or by hand.
@decaluwe This is being discussed as well in Cantera/enhancements#51 @ischoegl If this goes forward (I don't have a strong opinion either way), this would be a good place for @CanteraBot to make the commits. |
One nice thing here would be that we can 'release' examples as a zip file on a |
Regarding some of the other comments:
I think that can be handled by suitable PR templates.
Not sufficiently familiar, but sure!
Had not thought of that. But that offers another interesting option: a CI job (triggered on
@speth My overarching objective would be that a stand-alone repo would make it possible to direct new users to a single, easy-to-understand repository, where they can download all examples. As you pointed out in Cantera/enhancements#129, it is somewhat difficult to direct users to |
Not pursuing this beyond this point. |
Changes proposed in this pull request
A dedicated repository containing examples would make it easy to point new users to an easily accessible location where all examples are collected.
samples
andinterfaces/cython/cantera/examples
README.md
Note: This PR is meant to facilitate discussion. The destination repository currently does not exist (although the CI run was tested on ischoegl/cantera/actions/runs/1716150523). It is possible to tweak this idea further to copy to sub-folders in the destination repository. This means that it would be easy to copy files from
Cantera/cantera-jupyter
as well.If applicable, fill in the issue number this pull request is fixing
N/A, but see Cantera/enhancements#51, Cantera/enhancements#129
If applicable, provide an example illustrating new features this pull request is introducing
While there is no destination repository in the main Cantera repository at the moment, a (no-frills) example can be checked at ischoegl/cantera-samples
Checklist
scons build
&scons test
) and unit tests address code coverage