-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement serialization of Peng-Robinson phases #1180
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
+ Coverage 65.35% 65.40% +0.05%
==========================================
Files 315 318 +3
Lines 45999 46178 +179
Branches 19531 19639 +108
==========================================
+ Hits 30062 30203 +141
- Misses 13445 13470 +25
- Partials 2492 2505 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much, @speth, both for the new capabilities and the significant cleanup of PengRobinson.
Everything looks good to me. I haven't downloaded and run installation to test, figuring that the test coverage would catch issues, but LMK if you'd like me to take that step.
No "real" changes below, only two comment lines that got moved that I think we'd probably be fine deleting.
The old values appear to have been copy-paste errors propagated from critProperties.xml.
18cdc8c
to
0d4cef3
Compare
@decaluwe Is this good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks, @speth
Changes proposed in this pull request
PengRobinson
classcritical-properties.yaml
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage