-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop deprecated 'U' open option and fix formatting (Python 3.11 build errors) #1326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mark! Aside from the two comments here, can you move the purely formatting changes into a separate commit and add a .git-blame-ignore-revs
file to the root of the repo with that commit hash in it? Thanks!
@bryanwweber thanks for the review. |
84cebf6
to
1f35364
Compare
1f35364
to
94bfe67
Compare
Thanks @mefuller! I pushed a small change to just delete the commented out Once CI passes, I think this is good to go. |
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
Closes #1325
If applicable, provide an example illustrating new features this pull request is introducing
Test builds: https://koji.fedoraproject.org/koji/taskinfo?taskID=88565565
Checklist
scons build
&scons test
) and unit tests address code coverage