Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop deprecated 'U' open option and fix formatting (Python 3.11 build errors) #1326

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

mefuller
Copy link
Contributor

@mefuller mefuller commented Jun 7, 2022

Changes proposed in this pull request

  • site_scons/site_tools/subst.py resided to removed deprecated 'U' option which otherwise prevented building with Python 3.11

If applicable, fill in the issue number this pull request is fixing

Closes #1325

If applicable, provide an example illustrating new features this pull request is introducing

Test builds: https://koji.fedoraproject.org/koji/taskinfo?taskID=88565565

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark! Aside from the two comments here, can you move the purely formatting changes into a separate commit and add a .git-blame-ignore-revs file to the root of the repo with that commit hash in it? Thanks!

site_scons/site_tools/subst.py Outdated Show resolved Hide resolved
site_scons/site_tools/subst.py Outdated Show resolved Hide resolved
@mefuller
Copy link
Contributor Author

@bryanwweber thanks for the review.
Is there a Python 3.11 build that can now be enabled for Cantera CI?

@bryanwweber
Copy link
Member

Thanks @mefuller! I pushed a small change to just delete the commented out print and return statements. As far as testing on 3.11 goes, I assume that this will fix the problem. We decided in #1287 not to bump the Python version in CI quite yet, as there are likely to be other spurious failures like this that we can either collect or resolve as we get PRs for them without worrying about the status of the CI suite.

Once CI passes, I think this is good to go.

@bryanwweber bryanwweber merged commit 5898c7d into Cantera:main Jun 23, 2022
matthiasdiener added a commit to regro-cf-autotick-bot/cantera-feedstock that referenced this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cantera fails to build with Python 3.11: ValueError: invalid mode: 'rU'
2 participants