Python 3.11 support #1406
Merged
Python 3.11 support #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was removed from Python.h in Python 3.11. See python/cpython#28970
bryanwweber
reviewed
Nov 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #1406 +/- ##
==========================================
- Coverage 71.16% 71.15% -0.02%
==========================================
Files 373 373
Lines 52281 52276 -5
Branches 17374 17374
==========================================
- Hits 37206 37196 -10
- Misses 12721 12725 +4
- Partials 2354 2355 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
speth
force-pushed
the
python-3.11-support
branch
11 times, most recently
from
c7b45e0
to
80a6d9c
Compare
speth
force-pushed
the
python-3.11-support
branch
4 times, most recently
from
4124624
to
6b56019
Compare
The functions 'bandGBTRF' and 'bandGBTRS' were renamed in Sundials 6.0, with the old names deprecated and slated for removal in Sundials 7.0. The new names are 'SUNDlsMat_bandGBTRF' and 'SUNDlsMat_bandGBTRS'.
Linking to libpython with GitHub's Python 3.8 and 3.10 requires linking to libintl, but no compatible version of this library is present in the GitHub actions images (the Homebrew one has the wrong "macOS deployment target"). This problem is fixed in GitHub's build of Python 3.11. Scons 4.4.0 (and maybe other versions) can't be pip installed for the Homebrew Python, since it tries to write man pages into an incorrect, read-only directory. The Homebrew-installed Python was never actually being used. All macOS builds are done using Python cached in the GitHub actions image.
speth
force-pushed
the
python-3.11-support
branch
2 times, most recently
from
c11aaba
to
264a148
Compare
PyPI packages are not always available for the most recent Python version on all platforms.
speth
force-pushed
the
python-3.11-support
branch
from
264a148
to
4577ecf
Compare
|
After a mere 26 CI runs, this is finally working and ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
python3, instead of the other specific Python versions which are only installed aspython3.9etc.libintl) for linking tolibpython3.x.If applicable, fill in the issue number this pull request is fixing
Closes #1349
Checklist
scons build&scons test) and unit tests address code coverage