-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add safeguards against Python 3.12 #1467
Conversation
cfd4c5b
to
33b4a03
Compare
469e3d7
to
32a19f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ingmar! Couple of comments
32a19f2
to
a4eba13
Compare
ce33b2b
to
9ed294e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
09a7540
to
31fcc47
Compare
@bryanwweber ... thanks for your comments. Based on feedback, I updated the approach and am now conditioning behavior on the |
54fc968
to
e9812f3
Compare
Thanks for the change @ischoegl! I had one small nitpick from my previous review. |
e9812f3
to
c07109f
Compare
@bryanwweber … I believe that all comments are addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ischoegl LGTM. One question for my own edification 😄
Changes proposed in this pull request
Implement safeguards against Python 3.12 in
main
; the PR replicates similar changes implemented in #1465 for updates of Cantera 2.6. Edit: added a check in SCons to abort attempts that will fail before compiling.Checklist
scons build
&scons test
) and unit tests address code coverage