Remove unused configuration variables #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SOLARIS variable is no longer used in the C++ code.
The NEED_ALT_MAIN variable is not defined anywhere in the code
Codecov Report
@@ Coverage Diff @@
## main #1472 +/- ##
==========================================
+ Coverage 69.88% 69.90% +0.02%
==========================================
Files 377 377
Lines 57298 57301 +3
Branches 19164 19164
==========================================
+ Hits 40040 40054 +14
+ Misses 14705 14694 -11
Partials 2553 2553
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ischoegl
force-pushed
the
remove-solaris-variable
branch
2 times, most recently
from
aec18d8
to
8c00ccc
Compare
ischoegl
force-pushed
the
remove-solaris-variable
branch
from
8c00ccc
to
1b0e3a2
Compare
|
Thanks! I removed the references as suggested. PS: ended up also removing references to Win XP and Win 2000 ... |
Its only use is to set an alternative location for input data on macOS
Per release notes, Boost dll support was introduced in 1.61, see: https://www.boost.org/users/history/version_1_61_0.html
ischoegl
force-pushed
the
remove-solaris-variable
branch
from
1b0e3a2
to
e459a11
Compare
speth
approved these changes
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Remove (mostly) unused environment variables in
config.hSOLARISis unusedNEED_ALT_MAINis used by a Fortran example but nowhere defined; there is no evidence of this being used outside of CanteraLAPACK_NAMES_LOWERCASEhas a SCons option, but is nowhere mentioned in C++ or Fortran; there is no evidence of this being used outside of CanteraCT_USE_DEMANGLEis only required for Boost <1.56. The newly required DLL support was introduced in 1.61DARWINis only used to set an obscure data location/Applications/Cantera/data- it may be used forcantera-macos-pkg, but I am not sure how much use the installer sees; its main use appears to be for an installation with Matlab, but I believe that the toolbox is broken for M1?Checklist
scons build&scons test) and unit tests address code coverage