Fix memory management errors in ExtensibleRate #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a case not handled by 2158ff9 for "weak" wrappers where errors could occur if the destructor for the weak wrapper was called after the destructor for the owning Solution object. Fixes Cantera#1489
The code for instantiating Python Solution wrappers for phases adjacent to an interface did not link them as the wrapper to be used by ExtensibleRate objects.
Codecov Report
@@ Coverage Diff @@
## main #1499 +/- ##
=======================================
Coverage 69.49% 69.50%
=======================================
Files 377 377
Lines 57995 58011 +16
Branches 20693 20695 +2
=======================================
+ Hits 40305 40318 +13
- Misses 14739 14741 +2
- Partials 2951 2952 +1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
weak_ptrto know whether the C++Solutionobject still exists before callingremoveChangedCallback.PythonHandlefrom PythonChecklist
scons build&scons test) and unit tests address code coverage