Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of reference pressure in MultiSpeciesThermo #1503

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

speth
Copy link
Member

@speth speth commented Jun 13, 2023

Changes proposed in this pull request

  • Require all species in a phase to have the same reference pressure.
  • Set the reference pressure for the phase based on the first species added (instead of ignoring the value specified by the species)

If applicable, fill in the issue number this pull request is fixing

Closes #1435

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Require all species in a phase to have the same reference pressure.

Fixes Cantera#1435
@speth speth added the Thermo label Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #1503 (a0f2fa4) into main (e2cdb1c) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main    #1503   +/-   ##
=======================================
  Coverage   69.77%   69.77%           
=======================================
  Files         377      377           
  Lines       58011    58017    +6     
  Branches    20695    20701    +6     
=======================================
+ Hits        40479    40484    +5     
- Misses      14577    14578    +1     
  Partials     2955     2955           
Impacted Files Coverage Δ
include/cantera/thermo/MultiSpeciesThermo.h 100.00% <ø> (ø)
src/thermo/MultiSpeciesThermo.cpp 60.65% <83.33%> (+1.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@speth - thanks! Changes all look good to me.

@speth speth merged commit 5973dbd into Cantera:main Jun 14, 2023
@speth speth deleted the fix-1435-ref-pressure branch June 14, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference pressures: bars or atmospheres?
2 participants