Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building MATLAB toolbox on Apple Silicon #1524

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

speth
Copy link
Member

@speth speth commented Jul 3, 2023

Changes proposed in this pull request

  • Add support for building MATLAB toolbox on Apple Silicon

The native builds of MATLAB for Apple Silicon require the "preview" release of MATLAB 2023b.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #1524 (3040c36) into main (2771e61) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1524      +/-   ##
==========================================
- Coverage   70.51%   70.50%   -0.01%     
==========================================
  Files         376      376              
  Lines       59075    59075              
  Branches    21219    21219              
==========================================
- Hits        41656    41652       -4     
- Misses      14341    14346       +5     
+ Partials     3078     3077       -1     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@speth speth merged commit 2cf33cf into Cantera:main Jul 3, 2023
39 of 40 checks passed
@speth speth deleted the matlab-mac-arm branch July 23, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants