Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCons] Add deprecation warning for icc compiler #1542

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Jul 10, 2023

Changes proposed in this pull request

Log deprecation warning if icc is detected.

If applicable, fill in the issue number this pull request is fixing

Closes #1539

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl requested a review from a team July 10, 2023 23:19
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1542 (9c959f3) into main (f89efe8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1542   +/-   ##
=======================================
  Coverage   70.50%   70.50%           
=======================================
  Files         376      376           
  Lines       59075    59075           
  Branches    21219    21219           
=======================================
  Hits        41649    41649           
  Misses      14348    14348           
  Partials     3078     3078           
Impacted Files Coverage Δ
interfaces/cython/cantera/onedim.py 82.63% <100.00%> (ø)
src/oneD/Boundary1D.cpp 55.39% <100.00%> (ø)
src/oneD/StFlow.cpp 82.18% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@speth speth merged commit 6fc22c4 into Cantera:main Jul 11, 2023
@ischoegl ischoegl deleted the deprecate-icc branch July 11, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Intel-oneAPI classic (icc) is deprecated
2 participants