-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize code #1565
Standardize code #1565
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1565 +/- ##
==========================================
+ Coverage 70.47% 70.48% +0.01%
==========================================
Files 379 379
Lines 59093 59093
Branches 21230 21230
==========================================
+ Hits 41643 41653 +10
+ Misses 14369 14360 -9
+ Partials 3081 3080 -1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Applied the items from Cantera/enhancements#181 that are easiest (mostly removing the redundant |
b4aa032
to
5be32d4
Compare
2f8ed63
to
a7e0e46
Compare
Rebased and ready for review. Doxygen bits moved to #1567. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the remaining items in Cantera/enhancements#181, I'd suggest bundling them into a single PR. I don't think splitting this across several PRs is particularly helpful to the review process.
Changes proposed in this pull request
compositionMap
byComposition
grouplist_t
andMaxExp
std::set
byset
If applicable, fill in the issue number this pull request is fixing
Partially addresses Cantera/enhancements#181
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage