-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted C++ / SCons cleanup #1574
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1574 +/- ##
==========================================
- Coverage 70.53% 70.52% -0.02%
==========================================
Files 379 379
Lines 59110 59122 +12
Branches 21232 21238 +6
==========================================
+ Hits 41695 41697 +2
- Misses 14340 14352 +12
+ Partials 3075 3073 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The test helpers we use for the pint-based tests require pint 0.17 or newer. This requirement doesn't extend to the cantera.with_units module, though, which works with with versions at least as far back as 0.10.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
PS: Regarding the removal of |
I don't think so. The only thing that |
I guess I misspoke: it's actually |
Changes proposed in this pull request
FMT_HEADER_ONLY
only for platforms and fmt versions where necessary (revises fix for MSVC failures with fmt 7.1 #1540)vector<vector<double> >
tovector<vector<double>>
begin()
/end()
methods of matrix classesReactorSurface
data fromWallBase
cantera.pc
Checklist
scons build
&scons test
) and unit tests address code coverage