-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vapor fraction as option for setting state in YAML files #784
Conversation
Any reason not to cover the error messages and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks good to me.
04674f9
to
66feab3
Compare
Eliminate the surprising behavior of defaulting to the equation of state for water if no model is specified.
66feab3
to
decf41c
Compare
Codecov Report
@@ Coverage Diff @@
## master #784 +/- ##
==========================================
+ Coverage 71.44% 71.46% +0.02%
==========================================
Files 372 372
Lines 43952 43980 +28
==========================================
+ Hits 31400 31430 +30
+ Misses 12552 12550 -2
Continue to review full report at Codecov.
|
@speth I added one more test of the failure condition where the substance is unknown, to make sure that change isn't reverted. Feel free to drop it if you don't think it's necessary. This just seemed like the easiest way to add that change without a bunch of back and forth about what I meant 😄 |
The new phase definition you added breaks the test |
Ensure that unknown pure-fluid-name values throw an error.
fd323de
to
f7c33c6
Compare
scons build
&scons test
) and unit tests address code coveragePlease fill in the issue number this pull request is fixing
Addressing a question from @ischoegl in on Cantera/cantera-website#91.
Changes proposed in this pull request
state
definitions for pure fluid phases. For the last one, requires the three variables to be self-consistent.pure-fluid-name
out of the phase definition gave you awater
object instead of throwing an exception.