-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure consistent extra columns in SolutionArray #931
Conversation
6e6883e
to
cca2fef
Compare
@speth / @bryanwweber ... I cannot request a review, but I’d appreciate if those fixes could make it into 2.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[minor edits are taken care of]
cca2fef
to
318eedb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are useful improvements to eliminate some confusing behavior in the SolutionArray
class. Just noticed a couple of things to fix up further.
- Ensure consistent dimensions for extra columns - Enable multi-dimensional extra 'columns'
86f327f
to
47c11ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
Changes proposed in this pull request
extra
columns are consistentextra
'columns' (e.g. 2D arrays similar to what already exists for otherSolutionArray
attributes)If applicable, fill in the issue number this pull request is fixing
Fixes #895, fixes #930
Illustration
Checklist
scons build
&scons test
) and unit tests address code coverage