-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thermal conductivity to DustyGas in python. #988
Conversation
Codecov Report
@@ Coverage Diff @@
## main #988 +/- ##
==========================================
+ Coverage 71.22% 72.40% +1.18%
==========================================
Files 377 364 -13
Lines 46272 46433 +161
==========================================
+ Hits 32955 33618 +663
+ Misses 13317 12815 -502
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @chinahg. This looks great. Coding looks straightforward, and I pulled the code to my machine and verified that it works in Python.
Two questions, both regarding demonstration/testing:
- Can we add some code demonstrating that this is functional in the dusty_gas.py example?
- It looks like test coverage increases as a result of this change, but unless I'm mistaken, it doesn't look like this specific capability is tested. Can you add something to the dustyGasTransport test problem to test that this function works?
Great job!
Thanks, @chinahg -- change to the example file looks simple but effective (both of those are good things, for the record 😉). Now if we can get something testing this in the associated test problem, this will be all ready to merge. 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@decaluwe, there are no code changes to the C++ implementation here, so I don't think there's anything to test in the C++ test. I think the coverage changes are all spurious, and just an indication that this should be rebased onto the current main
branch.
@chinahg, can you add a test to the Python test suite? You can add it to the TestDustyGas
class in interfaces/cython/cantera/test/test_transport.py
.
Good point, @speth -- thanks. |
Many thanks and excellent work, @chinahg! |
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
Fixes #
Checklist
scons build
&scons test
) and unit tests address code coverage