Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import all external libraries on every sync #1

Closed

Conversation

wcurrie
Copy link

@wcurrie wcurrie commented Nov 15, 2018

When building with jdk 10 compiler, bazel currently fails to include external dependencies in .jdeps files bazelbuild/bazel#5723 (comment). Even with the bazel builder. The (not officially supported) vanilla builder doesn't even attempt to output dependencies in .jdeps files (bazelbuild/bazel#6587).

This is a sledgehammer workaround of ignoring the working set and always including all external dependencies when importing a project (from bazelbuild/bazel#6587 (comment)):

It might make more sense to just provide a way to disable the Intellij plugins' jdeps handling and use the full classpath.

The root cause of bazel failing to output dependencies to .jdeps files is known google/error-prone-javac@9901a45 so hopefully that fix will eventually find its way into bazel upstream. Making this hack temporary.

@uri-canva
Copy link

Cherry picked as dce7e13 and pushed out with 1ae32c6.

@wcurrie wcurrie closed this Nov 18, 2018
@uri-canva
Copy link

It looks like this has been fixed with 0.21, thought I'm not sure how. The -hjar.jdeps files at least all contain third party jar references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants