Skip to content

Commit

Permalink
[chore] remove deprecated types (open-telemetry#10283)
Browse files Browse the repository at this point in the history
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
  • Loading branch information
codeboten authored and steves-canva committed Jun 13, 2024
1 parent 185298a commit c1c38fc
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 10 deletions.
25 changes: 25 additions & 0 deletions .chloggen/codeboten_rm-deprecated-request.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: exporterhelper

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: remove deprecated RequestMarshaler & RequestUnmarshaler types

# One or more tracking issues or pull requests related to the change
issues: [10283]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
10 changes: 0 additions & 10 deletions exporter/exporterhelper/request.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,6 @@ type RequestErrorHandler interface {
OnError(error) Request
}

// RequestMarshaler is a function that can marshal a Request into bytes.
//
// Deprecated: [v0.94.0] Use exporterqueue.Marshaler[Request] instead.
type RequestMarshaler func(req Request) ([]byte, error)

// RequestUnmarshaler is a function that can unmarshal bytes into a Request.
//
// Deprecated: [v0.94.0] Use exporterqueue.Unmarshaler[Request] instead.
type RequestUnmarshaler func(data []byte) (Request, error)

// extractPartialRequest returns a new Request that may contain the items left to be sent
// if only some items failed to process and can be retried. Otherwise, it returns the original Request.
func extractPartialRequest(req Request, err error) Request {
Expand Down

0 comments on commit c1c38fc

Please sign in to comment.