Skip to content

Commit

Permalink
[chore] remove TODO from confmap code (open-telemetry#10278)
Browse files Browse the repository at this point in the history
Remove a TODO comment on confmap/provider.go related to ChangeEvent.
This struct is used extensively in providers that rely on changes such
as:

https://github.com/signalfx/splunk-otel-collector/blob/main/internal/configsource/etcd2configsource/source.go#L84
  • Loading branch information
atoulme authored and steves-canva committed Jun 13, 2024
1 parent bd6c3ba commit ef1be56
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion confmap/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ type Provider interface {
type WatcherFunc func(*ChangeEvent)

// ChangeEvent describes the particular change event that happened with the config.
// TODO: see if this can be eliminated.
type ChangeEvent struct {
// Error is nil if the config is changed and needs to be re-fetched.
// Any non-nil error indicates that there was a problem with watching the config changes.
Expand Down

0 comments on commit ef1be56

Please sign in to comment.