Optimise copying of data
inputs in npm_install
and yarn_install
#41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repository_ctx.___
actions (e.g. spawning a process, working with files) are very slow vs. most other environments. To optimise copyingdata
dependencies this PR refactors_copy_data_dependencies
to;tar
.tar
was selected as;cp
only does this for directory copying, GNUcp
can via--parents
).--files-from
.rsync
would likely represent a more optimal solution, however I'm not very familiar with it. It may make sense as a follow up if there is sufficient room for improvement.