fix: entity sub-grid count when 0 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sCount as it fails for zero items (line 116)
…ding Gherkin test file to the LookupSteps.cs file (line 127 onwards)
|
@tdashworth, here is the pull request relating to the fixes we have made on the specflow bindings project. |
|
Looks good to me |
tdashworth
suggested changes
Sep 13, 2022
There was a problem hiding this comment.
Thanks for the contribution 😄 a couple of comments if you could look at, please.
Also, wasn't the same fix required for #137?
bindings/src/Capgemini.PowerApps.SpecFlowBindings/Steps/LookupSteps.cs
Outdated
Show resolved
Hide resolved
bindings/src/Capgemini.PowerApps.SpecFlowBindings/Steps/EntitySubGridSteps.cs
Outdated
Show resolved
Hide resolved
tdashworth
changed the title
|
After reviewing #137 again, it doesn't look to be the same solution. |
Commented out some code from EasyRepro and included the relevant link on GitHub relating to the issue. Co-authored-by: Tom Ashworth <tom.ashworth@capgemini.com>
|
Kudos, SonarCloud Quality Gate passed!
|
tdashworth
approved these changes
Sep 14, 2022
|
Thanks for the contribution @AhmedD43 @osagiestar and team. When merging you can specify the commit message. Please follow to convention commit pattern e.g. ‘fix: asserting sub-grid count when there are 0 actual rows’. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #138.
Approach
Bypasses the EasyRepro calls and instead retrieved the count of rows from the
x or ytext in the sub-grid footer.TODOs