Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First model and structure #6

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

First model and structure #6

wants to merge 13 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2018

Not only the first model was save but also notes on it.

Copy link
Member

@WendelHime WendelHime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide some tests for client?

Copy link
Member

@WendelHime WendelHime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add Travis configuration file for tests

WORKDIR /
RUN git clone http://github.com/BiondiVini/gykernel.git

CMD ["/bin/bash"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this container, there is no automation for this image, please fix it

Copy link
Member

@WendelHime WendelHime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add missing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant