Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F114 us848 ta1933 firebase model #40

Merged
merged 8 commits into from
Nov 30, 2022
Merged

Conversation

rpsutton
Copy link
Contributor

  • AuthModel and functions
    • SignUp()
    • SignIn()
    • SignOut()
    • ResetPassword()
  • ViewRouter
    • Necessary for controlling which views an authenticated user should see
  • Auth Views
    • Sign In View
    • Sign Up View
    • Reset password View
  • MetricsModel
    • Split struct
    • Ride struct
  • FirestoreModel
    • writeRide()

Copy link

@bobby-palko bobby-palko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left a couple small improvements to readability and performance, but otherwise great job 👍🏻

Rear Rider/Rear Rider/Auth/SignInView.swift Outdated Show resolved Hide resolved
Rear Rider/Rear Rider/Auth/SignUpView.swift Outdated Show resolved Hide resolved
rpsutton and others added 2 commits November 30, 2022 14:01
Co-authored-by: Bobby Palko <bobby@palko.dev>
Co-authored-by: Bobby Palko <bobby@palko.dev>
@bobby-palko bobby-palko self-requested a review November 30, 2022 19:05
Copy link

@bobby-palko bobby-palko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍🏻

@bobby-palko bobby-palko merged commit 3730f51 into main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants