F109 us905 ta2104 bt to wifi lidar #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove some whitespace - Add a docstring to the class. - Convert string formatting to f-format variant.
A device will connect, but then will get kicked off because the callback was called twice. This fixes the bug by introducing a check for the currently connected device. Also fix a bug in the BluetoothDevice class where `self._device` was not being assigned the correct dbus interface object.
The rate at which the accelerometer data is sent to the connected device through bluetooth notifications can be configured through a GATT descriptor.
jon-dez
requested changes
Dec 3, 2022
rear_rider_device/rear_rider_bluetooth_server/src/services/hello_world.py
Outdated
Show resolved
Hide resolved
rear_rider_device/rear_rider_bluetooth_server/src/services/hello_world.py
Outdated
Show resolved
Hide resolved
…lo_world.py Co-authored-by: Jonathan Mendez <48642222+jon-dez@users.noreply.github.com>
…lo_world.py Co-authored-by: Jonathan Mendez <48642222+jon-dez@users.noreply.github.com>
Co-authored-by: Jonathan Mendez <48642222+jon-dez@users.noreply.github.com>
jon-dez
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged main, F109-US905-TA2104-bt-to-wifi, and bluetooth-changes branches into this one.