Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chosen letter support (Unsets) #6636

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

Northmoc
Copy link
Contributor

A decent draft, I think

@Northmoc Northmoc added Game Mechanics Low priority Good for a rainy day Unfinity Wacky stuff labels Nov 26, 2024
@Hanmac
Copy link
Contributor

Hanmac commented Nov 27, 2024

In case you’re wondering, we’ve chosen to allow Y to be both a consonant and a vowel, depending on what the card cares about. Y? Because we’re nice, and because Y has a great legal team.

xD

@Hanmac
Copy link
Contributor

Hanmac commented Nov 28, 2024

Apropos Letter in Card Name, we should normalize them for names like Bartolomé so é counts as e

see:

public static String normalizeText(String text) {
if (text == null)
return IPaperCard.NO_ARTIST_NAME;
return Normalizer.normalize(text, Normalizer.Form.NFD);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game Mechanics Low priority Good for a rainy day Unfinity Wacky stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants