A0-4020: fix for fix accounts consumers underflow #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcin-Radecki
changed the title
Marcin-Radecki
changed the title
kostekIV
approved these changes
Mar 8, 2024
covered all controller accounts cases of underflow.
DamianStraszak
approved these changes
Mar 15, 2024
Marcin-Radecki
deleted the
A0-4020-fix-for-fix_accounts_consumers_underflow
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
# Description * added command to fix `consumers` overflow * fixed logic which queries `consumers` underflow ## Type of change Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) ## Compaion PR #1643
Marcin-Radecki
added a commit
that referenced
this pull request
Mar 20, 2024
`operations.fix_accounts_consumers_underflow` does not take into account controller != stash scenario, in which case `consumers` should not be incremented on stash account, but on the controller account. Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
operations.fix_accounts_consumers_underflowdoes not take into account controller != stash scenario, in which caseconsumersshould not be incremented on stash account, but on the controller account.Type of change
Please delete options that are not relevant.