Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A0-1396 Poseidon hash function #835

Merged
merged 23 commits into from
Jan 12, 2023
Merged

A0-1396 Poseidon hash function #835

merged 23 commits into from
Jan 12, 2023

Conversation

fbielejec
Copy link
Collaborator

Description

An instance of a (parameterized) Poseidon hash function to be used with the relations crate.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have added tests
  • I have made neccessary updates to the Infrastructure
  • I have made corresponding changes to the existing documentation
  • I have created new documentation
  • I have bumped spec_version and transaction_version
  • I have bumped aleph-client version if relevant

@fbielejec fbielejec changed the base branch from main to snarkeling December 29, 2022 11:21
@fbielejec fbielejec marked this pull request as draft December 29, 2022 11:21
@fbielejec fbielejec changed the title Poseidon hash function A0-1396 Poseidon hash function Jan 10, 2023
@fbielejec fbielejec marked this pull request as ready for review January 10, 2023 15:32
pmikolajczyk41
pmikolajczyk41 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@pmikolajczyk41 pmikolajczyk41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but maybe before following up with 2to1, I suggest creating SC with this preimage, just to measure time needed for this computation

poseidon/Cargo.toml Outdated Show resolved Hide resolved
poseidon/src/parameters.rs Show resolved Hide resolved
relations/Cargo.toml Show resolved Hide resolved
poseidon/src/lib.rs Show resolved Hide resolved
poseidon/src/lib.rs Outdated Show resolved Hide resolved
@fbielejec
Copy link
Collaborator Author

lgtm, but maybe before following up with 2to1, I suggest creating SC with this preimage, just to measure time needed for this computation

Sure, there is this task that I will take next: https://cardinal-cryptography.atlassian.net/browse/A0-1841

@pmikolajczyk41
Copy link
Member

regarding SC costs, you might find #852 helpful

mike1729
mike1729 requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@mike1729 mike1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments but nothing big. Great work to make it work!

poseidon/build.rs Outdated Show resolved Hide resolved
poseidon/src/lib.rs Outdated Show resolved Hide resolved
poseidon/src/parameters.rs Show resolved Hide resolved
poseidon/src/parameters.rs Show resolved Hide resolved
poseidon/src/lib.rs Outdated Show resolved Hide resolved
relations/src/preimage.rs Outdated Show resolved Hide resolved
relations/src/preimage.rs Show resolved Hide resolved
deuszx
deuszx reviewed Jan 11, 2023
View reviewed changes
poseidon/build.rs Outdated Show resolved Hide resolved
fbielejec and others added 4 commits January 11, 2023 15:37
@fbielejec
rename module
4f26032
@fbielejec
hardcoded separator
95fe7d8
@fbielejec
add test
5ac0222
@fbielejec @deuszx
Update poseidon/build.rs
7b16917 
Co-authored-by: deuszx <95355183+deuszx@users.noreply.github.com>
@fbielejec fbielejec merged commit 42934a5 into snarkeling Jan 12, 2023
@fbielejec fbielejec deleted the poseidon-hash-function branch January 12, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deuszx deuszx deuszx left review comments

@pmikolajczyk41 pmikolajczyk41 pmikolajczyk41 approved these changes

@mike1729 mike1729 mike1729 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fbielejec @pmikolajczyk41 @mike1729 @deuszx