Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-1770: Add basic interfaces used and exposed by sync #837

Merged
merged 6 commits into from
Dec 30, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions finality-aleph/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ mod nodes;
mod party;
mod session;
mod session_map;
#[allow(dead_code)]
mod sync;
#[cfg(test)]
pub mod testing;

Expand Down
96 changes: 96 additions & 0 deletions finality-aleph/src/sync/mod.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
use std::{
fmt::{Debug, Display},
hash::Hash,
};

mod substrate;

/// The identifier of a block, the least amount of knowledge we can have about a block.
pub trait BlockIdentifier: Clone + Hash + Debug + Eq {
/// The block number, useful when reasoning about hopeless forks.
fn number(&self) -> u32;
}

/// Informs the sync that it should attempt to acquire the specified data.
pub trait Requester<BI: BlockIdentifier> {
/// The sync should attempt to acquire justifications for this block.
fn request_justification(&self, id: BI);
}

/// The header of a block, containing information about the parent relation.
pub trait Header: Clone {
type Identifier: BlockIdentifier;

/// The identifier of this block.
fn id(&self) -> Self::Identifier;

/// The identifier of this block's parent.
fn parent_id(&self) -> Option<Self::Identifier>;
}

/// The verified justification of a block, including a header.
pub trait Justification: Clone {
kostekIV marked this conversation as resolved.
Show resolved Hide resolved
type Header: Header;
type Unverified;

/// The header of the block.
fn header(&self) -> &Self::Header;

/// Return an unverified version of this, for sending over the network.
fn into_unverified(self) -> Self::Unverified;
}

/// A verifier of justifications.
pub trait Verifier<J: Justification> {
type Error: Display;

/// Verifies the raw justification and returns a full justification if successful, otherwise an
/// error.
fn verify(&self, justification: J::Unverified) -> Result<J, Self::Error>;
}

/// A facility for finalizing blocks using justifications.
pub trait Finalizer<J: Justification> {
type Error: Display;

/// Finalize a block using this justification. Since the justification contains the header, we
/// don't need to additionally specify the block.
fn finalize(&self, justification: J) -> Result<(), Self::Error>;
kostekIV marked this conversation as resolved.
Show resolved Hide resolved
}

/// A notification about the chain state changing.
pub enum ChainStateNotification<BI: BlockIdentifier> {
/// A block has been imported.
BlockImported(BI),
/// A block has been finalized.
BlockFinalized(BI),
}

/// A stream of notifications about the chain state in the database changing.
#[async_trait::async_trait]
pub trait ChainStateNotifier<BI: BlockIdentifier> {
/// Returns a chain state notification when it is available.
async fn next(&self) -> ChainStateNotification<BI>;
}

/// The state of a block in the database.
pub enum BlockState<J: Justification> {
kostekIV marked this conversation as resolved.
Show resolved Hide resolved
/// The block is justified and thus finalized.
Justified(J),
/// The block is present, might be finalized if a descendant is justified.
Present(J::Header),
/// The block is not known.
Unknown,
}

/// The knowledge about the chain state.
pub trait ChainState<J: Justification> {
/// The state of the block.
fn state_of(&self, id: <J::Header as Header>::Identifier) -> BlockState<J>;

/// The header of the best block.
fn best_block(&self) -> J::Header;

/// The justification of the top finalized block.
fn top_finalized(&self) -> J;
}
46 changes: 46 additions & 0 deletions finality-aleph/src/sync/substrate.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
use std::hash::{Hash, Hasher};

use sp_runtime::traits::{CheckedSub, Header as SubstrateHeader, One, UniqueSaturatedInto};

use crate::sync::{BlockIdentifier, Header};

#[derive(Clone, Debug, PartialEq, Eq)]
pub struct BlockId<H: SubstrateHeader> {
hash: H::Hash,
number: H::Number,
}

impl<SH: SubstrateHeader> Hash for BlockId<SH> {
fn hash<H>(&self, state: &mut H)
where
H: Hasher,
{
self.hash.hash(state);
self.number.hash(state);
}
}

impl<H: SubstrateHeader> BlockIdentifier for BlockId<H> {
fn number(&self) -> u32 {
self.number.unique_saturated_into()
maciejnems marked this conversation as resolved.
Show resolved Hide resolved
}
}

impl<H: SubstrateHeader> Header for H {
type Identifier = BlockId<H>;

fn id(&self) -> Self::Identifier {
BlockId {
hash: self.hash(),
number: *self.number(),
}
}

fn parent_id(&self) -> Option<Self::Identifier> {
let number = self.number().checked_sub(&One::one())?;
Some(BlockId {
hash: *self.parent_hash(),
number,
})
}
}